Changeset 71 for trunk/Phergie/Plugin/Acronym.php

Timestamp:

02/25/08 01:38:31 (5 years ago)

Author:

tobias382

Message:

* Added support to the Acronym plugin for filtering responses to certain acronyms
* Modified the Acronym plugin to restrict lookups to instances where the acronym takes up the entire post
* Modified the Acronym and Url plugins to add a lookup timeout
* Modified the Nickserv plugin to extend AdminCommand? instead of Command
* Fixed an issue in the tinyUrl method of the base plugin class where lack of URL encoding of the passed URL resulted in truncation of the original URL when computing its TinyURL equivalent
* Modified getIni and setIni methods in and added getPluginIni and setPluginIni to the base plugin case to allow for easier access to both core and plugin-specific settings and modified existing plugins to use the new methods where appropriate

Files:

• trunk/Phergie/Plugin/Acronym.php (modified) (6 diffs)

trunk/Phergie/Plugin/Acronym.php

@@ -14 +14 @@
 * The limit configuration setting should be set to the maximum number of
 * potential meanings to return for any single given acronym.
+*
+* @todo Add a cache to avoid exceeding the acronymfinder.com daily lookup
+*       limit. Cache should be flushed daily.
 */
 class Phergie_Plugin_Acronym extends Phergie_Plugin_Abstract_Base
@@ -23 +26 @@
     */
     protected $limit;
+
+    /**
+    * List of acronyms for which responses should not be sent
+    *
+    * @var array
+    */
+    protected $filter;
 
     /**
@@ -45 +55 @@
     public function init()
     {
-        $limit = $this->getIni('limit');
+        $limit = $this->getPluginIni('limit');
         if ($limit < 0 || $limit === null) {
             $this->limit = 5;
@@ -51 +61 @@
             $this->limit = (int) $limit;
         }
+
+        $this->filter = array_filter(preg_split('/[ ,]/', $this->getPluginIni('filter')), 'strlen');
     }
 
@@ -87 +99 @@
         $message = $this->event->getArgument(1);
 
-        if (!preg_match('/((?:[A-Z]\.?){2,})\?/', $message, $acronym)) {
+        if (!preg_match('/((?:[A-Z]\.?){2,})\?/AD', $message, $acronym)) {
             return;
         }
 
         $acronym = str_replace('.', '', $acronym[1]);
+
+        if (in_array($acronym, $this->filter)) {
+            return;
+        }
 
         if (in_array($acronym, array('WHO', 'WHAT', 'WHERE', 'WHEN', 'WHY', 'HOW'))) {
@@ -100 +116 @@
         $opts = array('http' =>
             array(
+                'timeout' => 5,
                 'method' => 'GET',
                 'header' => 'Content-type: application/x-www-form-urlencoded',