Changeset 166 for trunk/service.php

Timestamp:

12/18/07 20:06:45 (5 years ago)

Author:

Lantash

Message:

Performance optimization in the web service method gallery_getalbums: Only perform one database query to obtain the number of pictures in each album.

File:

• trunk/service.php (modified) (2 diffs)

trunk/service.php

@@ -658 +658 @@
     $database = Core::getDatabase();
         
-        $database->setQuery("SELECT * FROM #__gallery_albums");
+        $database->setQuery("SELECT a.*, COUNT(p.albumid) AS pictures FROM #__gallery_albums AS a LEFT JOIN #__gallery_pictures AS p ON a.id = p.albumid GROUP BY a.id");
         $albumsResponse = $database->loadAssocList();
         
@@ -668 +668 @@
     
         foreach ($albumsResponse as $album) {
-                // Needs optimization
-                $database->setQuery("SELECT * FROM #__gallery_pictures WHERE albumid = " . (int) $album["id"]);
-                
         $albums[] = Array(
             "id"          => (int)    $album["id"],
             "name"        => (string) $album["name"],
             "description" => (string) $album["description"],
-            "pictures"    => (int)        $database->getNumRows($database->query())
+            "pictures"    => (int)        $album["pictures"]
                 );
         }