Changeset 889 for trunk/libs/hydrogen/src/adsr.cpp

Timestamp:

03/11/09 02:37:50 (4 years ago)

Author:

gabriel@…

Message:

Trigger note release instead of abrupt cutoff on note-off events.

(Thanks to Krzysztof Foltman for the patch.)

Issue was reported to the forums [1] that bass drum kicks on TR808
created a clicking sound when used with a MIDI controller. In the
sampler, NOTE OFF events create an abrupt mute on the instrument,
which creates a high-frequency click. This patch instead triggers a
release on the instrument, respecting the mute group of the
instrument.

[1]  http://www.hydrogen-music.org/forum/?action=show_thread&fid=0&thread=1034&page=1

Files:

• trunk/libs/hydrogen/src/adsr.cpp (modified) (1 diff)

trunk/libs/hydrogen/src/adsr.cpp

@@ -147 +147 @@
                 __release_value = __value;
                 __state = RELEASE;
+                __ticks = 0;
                 return __release_value;
         }