Changeset 889

Timestamp:

03/11/09 02:37:50 (4 years ago)

Author:

gabriel@…

Message:

Trigger note release instead of abrupt cutoff on note-off events.

(Thanks to Krzysztof Foltman for the patch.)

Issue was reported to the forums [1] that bass drum kicks on TR808
created a clicking sound when used with a MIDI controller. In the
sampler, NOTE OFF events create an abrupt mute on the instrument,
which creates a high-frequency click. This patch instead triggers a
release on the instrument, respecting the mute group of the
instrument.

[1]  http://www.hydrogen-music.org/forum/?action=show_thread&fid=0&thread=1034&page=1

Location:

trunk/libs/hydrogen/src

Files:

• adsr.cpp (modified) (1 diff)
• sampler/sampler.cpp (modified) (1 diff)

trunk/libs/hydrogen/src/adsr.cpp

@@ -147 +147 @@
                 __release_value = __value;
                 __state = RELEASE;
+                __ticks = 0;
                 return __release_value;
         }

trunk/libs/hydrogen/src/sampler/sampler.cpp

@@ -170 +170 @@
 void Sampler::note_off( Note* note )
 {
-//this is in work. i planing a sustain-curve that users can edit
-//in moment only stop_playing_notes delete the current playing note.
-        stop_playing_notes( note->get_instrument() );
-//also the note_off msg from midi keyboard should be recorded into drum pattern note_map.
-//all this will develop into branch: new_fx_rack_and_sample_fun
+        assert(note);
+        Instrument *pInstr = note->get_instrument();
+        // find the notes using the same instrument, and release them
+        for ( unsigned j = 0; j < __playing_notes_queue.size(); j++ ) {
+                Note *pNote = __playing_notes_queue[ j ];
+                if ( pNote->get_instrument() == pInstr ) {
+                        pNote->m_adsr.release();
+                }
+        }
 }