Changeset 92

Timestamp:

11/19/08 07:23:43 (4 years ago)

Author:

kluck

Message:

Fix for a very weird bug where the CS3 debugger calls all getters on all items before the constructor fires. See mailing list thread:

 http://osflash.org/pipermail/flashr_osflash.org/2008-November/000612.html

Location:

trunk/com/kelvinluck/flashr/core

Files:

• Flashr.as (modified) (4 diffs)
• FlashrRequest.as (modified) (1 diff)
• FlashrRequestQueue.as (modified) (1 diff)
• FlashrResponseHistory.as (modified) (2 diffs)

trunk/com/kelvinluck/flashr/core/Flashr.as

@@ -332 +332 @@
         function get cache():FlashrCache
         {
-                return FlashrCache.getInstance();
-        }
+                return _cache;
+        }
+
         function set cache(cache:FlashrCache):Void {}
         private var _cache:FlashrCache;
@@ -343 +344 @@
         function get queue():FlashrRequestQueue
         {
-                return FlashrRequestQueue.getInstance();
+                return _queue;
         }
         function set queue(q:FlashrRequestQueue):Void {}
+        private var _queue:FlashrRequestQueue;
         
         /**
@@ -378 +380 @@
         function get history():FlashrResponseHistory
         {
-                return FlashrResponseHistory.getInstance();
+                return _history;
         }
         function set history(frh:FlashrResponseHistory) {}
+        private var _history:FlashrResponseHistory;
         
         /**
@@ -401 +404 @@
         {
                 LogWrapper.getLog().debug(this+" created");
+                _cache = FlashrCache.getInstance();
+                _queue = FlashrRequestQueue.getInstance();
+                _history = FlashrResponseHistory.getInstance();
                 awaitingResponse = false;
                 EventDispatcher.initialize(this);

trunk/com/kelvinluck/flashr/core/FlashrRequest.as

@@ -94 +94 @@
         {
                 if (__querystring == undefined) {
-                        __querystring = _prepareQuerystring();
+                        // to fix a dodgy bug in the CS3 debugger where the getter is called before the constructor when debugging!!
+                        if (method) {
+                                __querystring = _prepareQuerystring();
+                        }
                 }
                 return __querystring;

trunk/com/kelvinluck/flashr/core/FlashrRequestQueue.as

@@ -53 +53 @@
         private function FlashrRequestQueue()
         {
+                LogWrapper.getLog().debug(this+" created");
                 _priorityQueue = new PriorityQueue();
         }

trunk/com/kelvinluck/flashr/core/FlashrResponseHistory.as

@@ +1 @@
+import com.kelvinluck.util.LogWrapper;
 import com.kelvinluck.flashr.core.FlashrResponseEvent;
 /**
@@ -55 +56 @@
         private function FlashrResponseHistory()
         {
+                LogWrapper.getLog().debug(this+" created");
                 _history = [];
         }