Changeset 285

Timestamp:

01/27/2010 07:48:17 PM (3 years ago)

Author:

deity

Message:

Some cleaning up of perl warnings

Location:

trunk/plugins

Files:

• nikto_core.plugin (modified) (7 diffs)
• nikto_httpoptions.plugin (modified) (1 diff)
• nikto_msgs.plugin (modified) (2 diffs)
• nikto_report_html.plugin (modified) (1 diff)
• nikto_report_text.plugin (modified) (1 diff)

trunk/plugins/nikto_core.plugin

@@ -97 +97 @@
    } 
    # print errors to STDERR
-   if ($line =~ /^+ ERROR\:/) { print STDERR "$line\n"; return; }
+   if ($line =~ /^\+ ERROR\:/) { print STDERR "$line\n"; return; }
    
    # don't print to STDOUT if output file is "-"
-   if ($CLI{'file'} eq "-") { return; }
+   if ((defined $CLI{file}) && ($CLI{'file'} eq "-")) { return; }
 
    # print to scan details to standard output if the users wants another format and is saving results to a file
@@ -619 +619 @@
  else                             { nprint("+ ERROR: Invalid output format"); exit; }
 
- if (($CLI{'file'} ne "") && ($CLI{'format'} eq "")) { nprint("+ERROR: Output file specified without a format"); exit; }
+ if ((defined $CLI{'file'}) && ($CLI{'format'} eq "")) { nprint("+ERROR: Output file specified without a format"); exit; }
  
  # verify readable dtd 
@@ -768 +768 @@
    my $host_ctr=1;
    my @hosts=split(/,/,$hostlist);
-   my @ports=split(/,/,$portlist);
+   my @ports=split(/,/,$portlist) if defined $portlist;
    my @checkhosts;
    my @results;
@@ -780 +780 @@
       if ($port =~ /-/)
       {
-         my $start, $end;
+         my ($start, $end);
          my @temp=split(/-/,$port);
          $start=$temp[0];
@@ -1190 +1190 @@
 {
    my ($hostname, $ip, $port) = @_;
-   my %m, %headers;
+   my (%m, %headers);
 
    $m->{hostname}=$hostname;
@@ -1271 +1271 @@
                if ($torun_plugin eq "ALL" ||
                    $pluginhash->{name} eq $torun_plugin) {
-                  $pluginhash->{run}=true;
+                  $pluginhash->{run}="true";
                }
             }
@@ -1994 +1994 @@
    my ($mark, $uri, $method, $data, $headers, $noclean) = @_;
    if ($CLI{'pause'} > 0) { sleep $CLI{'pause'}; }
-   my %request, %result;
+   my (%request, %result);
    setup_hash(\%request, $mark);
  

trunk/plugins/nikto_httpoptions.plugin

@@ -45 +45 @@
    my $aoptions = "$headers{allow}, ";
    my $poptions = "$headers{public}, ";
-   my ($allow_methods, $public_methods, $txt);
+   my ($allow_methods, $public_methods);
+   my $txt = "";
    my $dbarray;
 

trunk/plugins/nikto_msgs.plugin

@@ -64 +64 @@
       # Computer name 
       my $name=$CONTENT; 
-      $name =~ s#(^.*<ComputerName>)([a-zA-Z0-9]*)(</ComputerName>.*$)#\2#; 
+      $name =~ s#(^.*<ComputerName>)([a-zA-Z0-9]*)(</ComputerName>.*$)#$2#; 
       my $eposerver=$CONTENT; 
-      $eposerver =~ s#(^.*<ePOServerName>)([a-zA-Z0-9]*)(</ePOServerName>.*$)#\2#; 
+      $eposerver =~ s#(^.*<ePOServerName>)([a-zA-Z0-9]*)(</ePOServerName>.*$)#$2#; 
       add_vulnerability($mark,"Web server is a McAfee ePO agent, showing the hostname is $name and the ePO server is $eposerver.",80100,0);      
    } 
@@ -81 +81 @@
          { 
             $name=$line; 
-            $name =~ s#(^.*System Management Homepage for )([a-zA-Z0-9]*)(</font>.*$)#\2#; 
+            $name =~ s#(^.*System Management Homepage for )([a-zA-Z0-9]*)(</font>.*$)#$2#; 
          } 
          if ($line =~ "new ObjectIpAddresses") 
          { 
             my $ipaddr=$line; 
-            $ipaddr =~ s#(^.*new ObjectIpAddresses\(")([\d\.]+)("\);.*$)#\2#; 
+            $ipaddr =~ s#(^.*new ObjectIpAddresses\(")([\d\.]+)("\);.*$)#$2#; 
             nprint("$ipaddr"); 
             $ipaddrs .= " $ipaddr"; 

trunk/plugins/nikto_report_html.plugin

@@ -196 +196 @@
 }
 
-sub nikto_reports { }    # so core doesn't freak
-
 1;

trunk/plugins/nikto_report_text.plugin

@@ -53 +53 @@
 {
    my ($handle, $mark) = @_;
-   my $curr_host, $curr_port;
+   my ($curr_host, $curr_port);
    print $handle "+ Target Host: $mark->{hostname}\n";
    print $handle "+ Target Port: $mark->{port}\n";