Changeset 2325

Timestamp:

12/24/10 07:18:18 (17 months ago)

Author:

petsagouris

Message:

[Branch 1.5] Removing * in SQL queries see #204

Location:

branches/1.5/libs

Files:

• Post.php (modified) (2 diffs)
• UserInfo.php (modified) (2 diffs)

branches/1.5/libs/Post.php

@@ -126 +126 @@
         {
                 // Build SQL
-                $query = "SELECT * FROM " . TABLE_POSTS . " WHERE post_id = %d ORDER BY post_date DESC";
+                $query = "SELECT post_id,post_orig_url FROM " . TABLE_POSTS . " WHERE post_id = %d ORDER BY post_date DESC";
                 $sql = $h->db->prepare($query, $post_id);
                 
@@ -295 +295 @@
                 
                 // One last check to see if a post is present:
-                $sql = "SELECT * FROM " . TABLE_POSTS . " WHERE post_orig_url = %s LIMIT 1";
+                $sql = "SELECT post_id, post_status FROM " . TABLE_POSTS . " WHERE post_orig_url = %s LIMIT 1";
                 $post = $h->db->get_row($h->db->prepare($sql, $url));
                 

branches/1.5/libs/UserInfo.php

@@ -102 +102 @@
         public function isAdmin($db, $username)
         {
-                $sql = "SELECT * FROM ".TABLE_USERS." WHERE user_username = %s AND user_role = %s  LIMIT 1";
+                $sql = "SELECT user_id FROM ".TABLE_USERS." WHERE user_username = %s AND user_role = %s  LIMIT 1";
                 return (bool) $db->get_row($db->prepare($sql, $username, 'admin'));
         }
@@ -272 +272 @@
                 if (!$id_array) {
                         // get all users
-                        $sql = "SELECT * FROM ".TABLE_USERS." ORDER BY user_username ASC";
+                        $sql = "SELECT user_id,user_username FROM ".TABLE_USERS." ORDER BY user_username ASC";
                         $results = $h->db->get_results($sql);
                 } else {
-                        // for grabbing 
-                        if ($range) {
-                                $limit = " LIMIT ".$start.", ".$range;
-                        }
-                        $sql = "SELECT * FROM ".TABLE_USERS." WHERE ";
+
+                        $sql = "SELECT user_id,user_username FROM ".TABLE_USERS." WHERE ";
                         for ($i = 0; $i < count($id_array); $i++) {
                                 $sql .= "user_id = %d OR ";
                         }
                         $sql = rstrtrim($sql, "OR "); // strip trailing OR
-                        $sql .= " ORDER BY user_username ASC".$limit;
+                        $sql .= " ORDER BY user_username ASC".(($range) ? " LIMIT ".$start.", ".$range : '');
 
                         $prepare_array[0] = $sql;